Messages in this thread | | | Date | Thu, 17 Apr 2008 14:01:34 +0200 | From | "Boris Petkov" <> | Subject | Re: [PATCH 3/6] IDE: ide-cd: fix test unsigned var < 0 |
| |
On Thu, Apr 17, 2008 at 1:04 PM, Roel Kluin <12o3l@tiscali.nl> wrote: > Boris Petkov wrote: > > > I'd rather keep the "unsigned long bio_sectors;" part and do something > > of the likes of: > > > > bio_sectors = bio_sectors(failed_command->bio); > > > > > > (remove the "if (bio_sectors < 4)"-test) > > > > ... and later... > > > > sector &= ~(max(bio_sectors - 1, 3)); > > > > which is, IMO, more readable. > > > > Roel, would you redo your patch please? Thanks. > > While at it I also cleaned up some whitespace > > --- > Clean up cdrom_analyze_sense_data() > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
Thanks a lot.
Acked-by: Borislav Petkov <petkovbb@gmail.com>
-- Regards/Gruß, Boris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |