lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: gart: factor out common code
On 4/16/08, Pavel Machek <pavel@ucw.cz> wrote:
> On Tue 2008-04-15 16:25:29, SL Baur wrote:
> > On 4/15/08, Pavel Machek <pavel@ucw.cz> wrote:

> > Other reviewer comments:
> > The casting between struct pci_dev * and u64 is kind of ugly,
> > I presume the reason for the narrowing casts in the block of
> > code you moved is documented somewhere.
>
>
> Where am I doing that?

The struct pci_dev */u64 casting is in init_k8_gatt. If Ingo is happy, then
forget my comment. I don't have this kind of system to test the patch on, it
was just that as I was looking it over, all the casts kind of made my head
swim.

The narrowing cast is here:
+static inline void enable_gart_translation(struct pci_dev *dev, u64 addr)
+{
+ u32 tmp, ctl;
+
+ /* address of the mappings table */
+ addr >>= 12;
+ tmp = (u32) addr<<4;

Also, putting on my Andrew Morton cap, which I should have done before,
that function is too big to be inlined so you should probably drop the explicit
`inline' and let the compiler decide.

Add a
Reviewed-by: SL Baur <steve@xemacs.org>
if that's appropriate. I'm satisified that you did a one-for-one code move.

-sb


\
 
 \ /
  Last update: 2008-04-17 04:59    [W:0.040 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site