Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 3/9] ide: add ->tf_load and ->tf_read methods | Date | Thu, 17 Apr 2008 00:22:30 +0200 |
| |
On Wednesday 16 April 2008, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > > * Add ->tf_load and ->tf_read methods to ide_hwif_t and set the default > > methods in default_hwif_transport(). > > It's not clear to me what do we gain with addign such methods...
in short-term not much besides a nice optimization
in long-term it should enable us to remove ->IN*/OUT* methods completely
> > * Use ->tf_{load,read} instead o calling ide_tf_{load,read}() directly. > > > * Make ide_tf_{load,read}() static. > > > There should be no functional changes caused by this patch. > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
| |