Messages in this thread | | | Date | Wed, 16 Apr 2008 10:14:18 +0200 | From | Pavel Machek <> | Subject | Re: gart: factor out common code |
| |
On Tue 2008-04-15 16:25:29, SL Baur wrote: > On 4/15/08, Pavel Machek <pavel@ucw.cz> wrote: > > Cleanup gart handling on amd64 a bit: move common code into > > enable_gart_translation , and use symbolic register names where > > appropriate. > > > > Signed-off-by: Pavel Machek <pavel@suse.cz> > > Which source tree is this patch against? I'm looking at Linus > latest and I don't see the AMD64_* constants defined in the > same place.
x86 tree, hopefully.
> Other reviewer comments: > The casting between struct pci_dev * and u64 is kind of ugly, > I presume the reason for the narrowing casts in the block of > code you moved is documented somewhere.
Where am I doing that? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |