lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Current git tree broke busybox start-stop-daemon
On Wed, Apr 16, 2008 at 11:00:57PM +0400, Alexey Dobriyan wrote:
> On Wed, Apr 16, 2008 at 07:25:02PM +0200, Joakim Tjernlund wrote:
> > open("/proc/1/stat", O_RDONLY|O_LARGEFILE) = 4
> > _llseek(4, 0, 0xbfb94898, SEEK_END) = -1 EINVAL (Invalid argument)
>
> > So it appears that lseek is no longer allowed for /proc/1/stat
> > Bug or feature?
> > start-stop-daemon works fine in 2.6.23
>
> That's what happens when switching ->llseek method from NULL
> (effectively, default_llseek), to seq_lseek (which rejects SEEK_END).
>
> commit be614086a4aff163d5aa0dc160638d1193b59cde
> commit ee992744ea53db0a90c986fd0a70fbbf91e7f8bd
>
> Al, do you remember why SEEK_END was omitted back then?

Because there's no sane way to implement it? Note that original cheerfully
did nothing, since it had zero ->i_size for that file. Which makes program
in question very odd - what behaviour does it rely upon?


\
 
 \ /
  Last update: 2008-04-16 21:37    [W:0.078 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site