Messages in this thread | | | Date | Wed, 16 Apr 2008 12:07:52 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH][RFC] Add default CPU topology information |
| |
On Wed, 16 Apr 2008 14:51:33 +0200 Ingo Molnar <mingo@elte.hu> wrote:
> > * Andrew Morton <akpm@linux-foundation.org> wrote: > > > > This patch: > > > > > > - Adds default definitions of the 4 topology macros to > > > include/asm-generic/topology.h. > > > - Changes include/asm-*/topology.h to include <asm-generic/topology.h> > > > unconditionally. > > > - Changes drivers/base/topology.c to use the topology macros unconditionally > > > and to cope with definitions that aren't lvalues. > > > - Updates documentation accordingly. > > > > > > > I ran away in terror when I saw this patch. It's dark and dirty stuff > > you're unearthing there and it looks like a minefield of compilation > > problems. Not aided by the fact that we don't have a topology > > maintainer afaik. > > > > We shall see. > > i could pick it up into sched.git
There seem to be multiple sched.gits
> - it's a frequent party to topology > patches. We've now got automated cross-build checks as well by virtue of > Thomas so common build failures ought to be rare.
OK, whatever. There's a tangle between this change and the s390 tree which already has a tangle with one of the sched-gits which is sort-of getting sorted out.
git-s390 wasn't an appropriate place to host changes to drivers/base/topology.c.
| |