lkml.org 
[lkml]   [2008]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -mm] relayfs: support larger relay buffer
Hi Pekka,

Pekka Enberg wrote:
> On Tue, Apr 15, 2008 at 6:27 PM, Masami Hiramatsu <mhiramat@redhat.com> wrote:
>> Use vmalloc() and memset() instead of kcalloc() to allocate a page* array
>> when the array size is bigger than one page. This enables relayfs to support
>> bigger relay buffers than 64MB on 4k-page system, 512MB on 16k-page system.
>>
>> Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
>> ---
>> @@ -130,7 +138,10 @@ static void *relay_alloc_buf(struct rcha
>> depopulate:
>> for (j = 0; j < i; j++)
>> __free_page(buf->page_array[j]);
>> - kfree(buf->page_array);
>> + if (pa_size > PAGE_SIZE)
>
> You can use is_vmalloc_addr() here.

Thank you for your good advice!
I'll use that.

>
>> + vfree(buf->page_array);
>> + else
>> + kfree(buf->page_array);
>> return NULL;
>> }
>>

--
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@redhat.com



\
 
 \ /
  Last update: 2008-04-16 16:47    [W:0.063 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site