Messages in this thread | | | Date | Tue, 15 Apr 2008 00:49:18 -0700 (PDT) | Subject | Re: [PATCH] netconsole: only set CON_PRINTBUFFER if the user specifies a netconsole | From | David Miller <> |
| |
From: Michael Ellerman <michael@ellerman.id.au> Date: Tue, 15 Apr 2008 17:43:12 +1000 (EST)
> Since 0bcc1816188e570bde1d56a208996660f2633ae0 (netconsole: Support > dynamic reconfiguration using configfs), the netconsole is always > registered, regardless of whether the user actually specified a > netconsole configuration on the command line. > > However because netconsole has CON_PRINTBUFFER set, when it is > registered it causes the printk buffer to be replayed to all consoles. > When there is no netconsole configured this is a) pointless, and b) > somewhat annoying for the user of the existing console. > > So instead we should only set CON_PRINTBUFFER if there is a netconsole > configuration found on the command line. This retains the existing > behaviour if a netconsole is setup by the user, and avoids spamming > other consoles when we're only registering for the dynamic > netconsole case. > > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
That's a regression, so applied to net-2.6, thanks Michael.
| |