Messages in this thread | | | From | Carlos Corbacho <> | Subject | Re: [PATCH 4/8] rfkill: add read-write rfkill switch support | Date | Tue, 15 Apr 2008 08:27:49 +0100 |
| |
On Monday 14 April 2008 21:23:14 Dmitry Torokhov wrote: > On Mon, Apr 14, 2008 at 08:06:50PM +0100, Carlos Corbacho wrote: > > I agree wholeheartedly with Henrique here though - wireless drivers > > should _not_ be using key press events as a reporting mechanism. > > Reporting mechanism for what exacly though? Depending on what you are > talking about we either agree or disagree here ;)
Reporting state change in this case. For instance, KEY_WLAN means exactly that - a user pressed a key that was mapped to KEY_WLAN. It's not a generic notifier for any and all wireless events, state changes, etc.
If wireless drivers want to report a state change, then we need a proper mechanism for that, as has already been discussed by Henrique.
-Carlos -- E-Mail: carlos@strangeworlds.co.uk Web: strangeworlds.co.uk GPG Key ID: 0x23EE722D
| |