Messages in this thread | | | Date | Tue, 15 Apr 2008 00:08:39 -0700 | From | "SL Baur" <> | Subject | Re: [PATCH] sysfs: add /sys/dev/{char, block} to lookup sysfs path by major:minor |
| |
On 4/14/08, Dan Williams <dan.j.williams@intel.com> wrote: > On Mon, Apr 14, 2008 at 8:13 PM, SL Baur <steve@xemacs.org> wrote: > > On 4/14/08, Dan Williams <dan.j.williams@intel.com> wrote:
> Thanks for looking it over. To be honest I was iffy about those > buffer sizes as well, and looking closer they are overkill. Although, > they are smaller than the 32-byte buffer in bsg.c :-). 13-bytes is all > that is needed given a 12-bit major and 20-bit minor. Care to send a > patch to fix up format_dev_t and print_dev_t?
O.K. I'll look into it. The call paths into format_dev_t are clear, the ones into print_dev_t look a bit more global.
-sb
| |