Messages in this thread | | | Subject | Re: [RFC PATCH 1/2] Marker probes in futex.c | From | Peter Zijlstra <> | Date | Tue, 15 Apr 2008 14:02:22 +0200 |
| |
On Tue, 2008-04-15 at 17:23 +0530, K. Prasad wrote:
> + trace_mark(futex_wait_called, "uaddr:%p fshared:%p val:%u " > + "abs_time:%p bitset:%d", > + uaddr, fshared, val, abs_time, bitset);
This is some seriuosly ugly looking gunk, why would we want stuff like that scattered across the code?
What is wrong with a few simple hooks like:
trace_futex_wait(uaddr, fshares, val, abs_time, bitset);
and then deal with that.
Also, you seem to expose way too much futex internals; do you really need that? People will go use this marker crap like ABI and further restrain us from changing the code.
/me unhappy.
| |