Messages in this thread | | | Date | Mon, 14 Apr 2008 10:03:51 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 2/2] printk: Remember the message level for multi-line output |
| |
* Nick Andrew <nick@nick-andrew.net> wrote:
> printk: Remember the message level for multi-line output > > printk(KERN_ALERT "Danger Will Robinson!\nAlien Approaching!\n"); > > At present this will result in one message at ALERT level and one at > the current default message loglevel (e.g. WARNING). This is > non-intuitive. > > Modify vprintk() to remember the message loglevel each time it is > specified and use it for subsequent lines of output which do not > specify one, within the same call to printk.
i've applied this too for testing.
but multi-line strings are a bit unclean i think: each message line should have its separate printk.
will your patch leave the behavior of multiple calls to printk alone? I.e. if i do:
printk(KERN_ALERT "Danger Will Robinson!\n"); printk("Alien Approaching!\n");
then we'll still get a KERN_ALERT plus a default printk, right? In that case my earlier observation about this patch is moot and i guess it's fine to do this.
Ingo
| |