Messages in this thread | | | Date | Mon, 14 Apr 2008 17:22:16 -0500 | From | David Fries <> | Subject | Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug |
| |
On Mon, Apr 14, 2008 at 03:40:55PM +0400, Evgeniy Polyakov wrote: > Hi David. > > On Sun, Apr 13, 2008 at 06:15:37PM -0500, David Fries (david@fries.net) wrote: > > This is more to point out the bug in w1_slave_read_id, the next patch > > rewrites the routine. > > > > w1.c 1.15 > ... > > w1.c 1.16 > > > That is what I talked about. I agree with your analysis of the problem > and I agree with fixes. But I do not agree with how you created them: > why do we ever neen 1.15 version, since immediately after that we have > 1.16 which completely rewrite what was done in previous one? > This applies to the whole patchset: there are essentially several bug > fixes and several features, so separate them into several patches, which > do not collide with each other in the above way.
The old patch 14/35 and 15/35 was the only place I know of where I fixed the bug, then replaced it wholesale with something better. Several bugs, a few features, lots of patches, go figure.
-- David Fries <david@fries.net> http://fries.net/~david/ (PGP encryption key available)
| |