Messages in this thread | | | Date | Mon, 14 Apr 2008 12:39:17 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2] fix sys_unshare()+SEM_UNDO: add support for CLONE_SYSVSEM |
| |
On Mon, 14 Apr 2008 09:58:40 -0500 "Serge E. Hallyn" <serue@us.ibm.com> wrote:
> Quoting Manfred Spraul (manfred@colorfullife.com): > > Andrew Morton wrote: > >> On Sun, 13 Apr 2008 10:04:17 +0200 Manfred Spraul > >> <manfred@colorfullife.com> wrote: > >> > >>> sem_undo_list **new_ulistp) > >>> { > >>> - if (unshare_flags & CLONE_SYSVSEM) > >>> - return -EINVAL; > >>> + if (unshare_flags & CLONE_SYSVSEM) { > >>> + *new_ulistp = (void*)1; > >>> + } > >>> > >> > >> And can we do anything nicer than this? > >> > >> > > Attached is an alternative. If you prefer it, I'll send another patch set. > > FWIW I definately far far prefer this version :)
Oh, OK.
I guess I'll drop what I have. Manfred, can we please have a new patchset?
We might end up slipping this back to 2.6.25.1. Would that be a bad thing?
| |