lkml.org 
[lkml]   [2008]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.25-rc9 -- INFO: possible circular locking dependency detected

* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

> On Mon, Apr 14, 2008 at 08:54:05AM +0200, Peter Zijlstra wrote:
> > Fun,
> >
> > I will need to sort out this code before I can say anything about that,
> > perhaps Gautham and or Rafael have ideas before I can come up with
> > something.. ?
>
> Why not simply removing the get/put_online_cpus() pair in
> sched_getaffinity? It's superfluous since we have already a
> read_lock/read_unlock pair there which does disable/enable cpu hotplug
> anyway.

we dont want to insert such silent "preempt off == hotplug disable"
assumptions - which assumption breaks when the tasklist_lock becomes
preemptible (such as in -rt).

Ingo


\
 
 \ /
  Last update: 2008-04-14 09:21    [W:0.082 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site