lkml.org 
[lkml]   [2008]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-2.6.26] [IPV6] Return NET_RX_DROP when a packet is dropped in ipv6_rcv().
From
In article <eb3ff54b0804140615u3dd4549fie83ae6818c33beba@mail.gmail.com> (at Mon, 14 Apr 2008 16:15:54 +0300), "Rami Rosen" <ramirose@gmail.com> says:

> Hi,
> - The IPv6 handler for receiving packets is ipv6_rcv() in net/ipv6/ip6_input.c.
> It is called by netif_receive_skb() (net/core/dev.c)
> According to the documentation, the return value of netif_receive_skb() should
> be NET_RX_DROP when the packet is dropped; though this return value
> is usually not used (except maybe for congestion), this patch fixes the
> ipv6_rcv() to return NET_RX_DROP when the packet is dropped (note that
> NET_RX_DROP value **is not** 0 but 1; NET_RX_SUCCESS value is in fact 0).

Well yes, and I think we should fix other paths as well, right?
So, I'm going to defer this for now.

--yoshfuji


\
 
 \ /
  Last update: 2008-04-14 15:53    [W:0.176 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site