Messages in this thread | | | Date | Mon, 14 Apr 2008 15:40:55 +0400 | From | Evgeniy Polyakov <> | Subject | Re: [PATCH 13/33 replaces 14/35 and 15/35] W1: w1_slave_read_id multiple short read bug |
| |
Hi David.
On Sun, Apr 13, 2008 at 06:15:37PM -0500, David Fries (david@fries.net) wrote: > This is more to point out the bug in w1_slave_read_id, the next patch > rewrites the routine. > > w1.c 1.15 ... > w1.c 1.16
That is what I talked about. I agree with your analysis of the problem and I agree with fixes. But I do not agree with how you created them: why do we ever neen 1.15 version, since immediately after that we have 1.16 which completely rewrite what was done in previous one? This applies to the whole patchset: there are essentially several bug fixes and several features, so separate them into several patches, which do not collide with each other in the above way.
-- Evgeniy Polyakov
| |