Messages in this thread | | | Date | Mon, 14 Apr 2008 12:28:27 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH] sound/pci/rme9652/hdspm.c: stop inlining largish static functions |
| |
At Tue, 1 Apr 2008 04:36:48 +0200, Denys Vlasenko wrote: > > Hi Takashi, > > Can you please take a look at this patch? > > sound/pci/rme9652/hdspm.c has unusually large number > of static inline functions - 22. > > I looked through them and some of them seem to be too big > to warrant inlining. > > This patch removes "inline" from these static functions > (regardless of number of callsites - gcc nowadays auto-inlines > statics with one callsite). > > Size difference on 32bit x86: > text data bss dec hex filename > 20437 2160 516 23113 5a49 linux-2.6-ALLYES/sound/pci/rme9652/hdspm.o > 18036 2160 516 20712 50e8 linux-2.6.inline-ALLYES/sound/pci/rme9652/hdspm.o > > Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com> > -- > vda
Thanks for the patch. I applied it to ALSA tree together with coding style fixes.
Takashi
| |