lkml.org 
[lkml]   [2008]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: pgtable_32.h - prototype and section mismatch fixes

* Sam Ravnborg <sam@ravnborg.org> wrote:

> > hm, that's an interesting case: we need those annotations probably
> > because gcc decided to not inline those functions. (this is possible
> > via the new CONFIG_OPTIMIZE_INLINING=y option) Sam, what's your take
> > on that?
>
> gcc uses different heuristics for inlining between the different
> versions. Therefore to achieve somehow predictable results I added
> -fno-inline-functions-called-once when CONFIG_DEBUG_SECTION_MISMATCH
> is enabled.
>
> So in the above case for any normal kernel build we would see that gcc
> inlined the above and everything is fine. But for the
> CONFIG_DEBUG_SECTION_MISMTCH cases we do not inline and thus we see
> that we have a section mismatch.

ah, ok. So i guess this will result in a few isolated cases of __init
annotations added to inline functions - Jacek fixed one such case - but
it should not result in the general spreading of __init annotations to
inline functions, correct? (which i was worried about)

Ingo


\
 
 \ /
  Last update: 2008-04-14 10:55    [W:0.066 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site