Messages in this thread | | | Subject | Re: [PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 8) | From | Benjamin Herrenschmidt <> | Date | Mon, 14 Apr 2008 13:23:00 +1000 |
| |
> To avoid breaking things (from the functional point of view) unnecessarily. > > In short, I don't really see the difference between moving ->prepare() before > the freezer and droppig the freezer, which I'm not going to do right now.
I believe the use of prepare for things like request_firmware etc... is worth the effort of fixing the known breakage of not having the freezer while preventing insertion of new devices (mostly USB). In fact, it won't be such a big issue as the core should/will return an error from attempting to add the device in that case.
Ben.
| |