lkml.org 
[lkml]   [2008]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] e1000=y && e1000e=m regression fix


On Fri, 11 Apr 2008, Jeff Garzik wrote:
> Linus Torvalds wrote:
> > .. but that said, I think your patch is certainly better than what we have
> > now (or what Ingo was complaining about for the next merge window). I
> > certainly could live with it. I would just suggest against ever then
> > removing that "generic E1000" choice.
>
> You mean never ever remove PCI-E support from e1000?

No. I mean never ever remove the *configure* level thinking that "e1000 is
e1000".

There is no sense in *ever* showing it as two drivers to users, because
users do not see them as separate chipsets. They look identical, down to
the part names.

If it's a single family, and users can't even easily tell whether they
have version 1 or version 2 (PCI vs PCI-E), you shouldn't even ask them.
You should literally ask them: "do you want e1000 support".

That's it.

Once you have asked them that, you can then decide "ok, if you *really*
know what version of the chip you have, you can decide to only get limited
driver support".

But that's a secondary thing from a user perspective.

See the patch I already sent out.

Linus


\
 
 \ /
  Last update: 2008-04-13 23:17    [W:0.113 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site