lkml.org 
[lkml]   [2008]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subject[rfc] hw resource debugging checks (was: Re: x86 git tree broken (bisected))

* Rafael J. Wysocki <rjw@sisk.pl> wrote:

> > > btw., Xorg works fine here on a comparable AMD system - but i use
> > > a rather new distro (Fedora 8) which has Xorg 7.2.
> >
> > My system is an OpenSUSE 10.3 and it has Xorg 7.2 as well.
> >
> > I think the problem is somehow related to the Radeon.
>
> The bisection turned up commit
> ea1441bdf53692c3dc1fd2658addcf1205629661 "x86: use bus conf in NB conf
> fun1 to get bus range on, on 64-bit" as the one causing problems.

thanks Rafael for bisecting this!

This was a rather nasty problem - and i'm wondering what else we could
do to harden our hw resource management code. I'm wondering, is there
any particular reason why clearly broken resource setup is not detected
somewhere, automatically, and WARN_ON()-ed about?

for example, in the scheduler code we used to have similar bug patterns
again and again: architecture code set up scheduler domains incorrectly
and broke the system in subtle ways. So we added sched_domain_debug()
which is active under CONFIG_SCHED_DEBUG=y and does a few sanity checks
and complains if something is wrong. This caught quite a few bugs
whenever the sched-domains code was modified.

Ingo


\
 
 \ /
  Last update: 2008-04-13 10:01    [W:0.115 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site