Messages in this thread | | | Date | Sun, 13 Apr 2008 09:42:25 +0200 | From | Ingo Molnar <> | Subject | Re: *_pagetable_setup_[start,done] crap ? |
| |
* Jacek Luczak <difrost.kernel@gmail.com> wrote:
> Ohh... and prototypes are wrong: > diff --git a/include/asm-x86/pgtable_32.h b/include/asm-x86/pgtable_32.h > index 6cbc520..2167879 100644 > --- a/include/asm-x86/pgtable_32.h > +++ b/include/asm-x86/pgtable_32.h > @@ -204,8 +204,8 @@ do { \ > */ > #define update_mmu_cache(vma, address, pte) do { } while (0) > > -void native_pagetable_setup_start(pgd_t *base); > -void native_pagetable_setup_done(pgd_t *base); > +extern void native_pagetable_setup_start(pgd_t *base) __init; > +extern void native_pagetable_setup_done(pgd_t *base) __init;
while generally it's nice to add 'extern' to prototypes, it's not an outright bug to not have it. Also, __init is a must-have in the definition only - it should not be added to the prototype.
Ingo
| |