lkml.org 
[lkml]   [2008]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sb1000.c: stop inlining largish static functions
Denys Vlasenko wrote:
> Hi Jeff,
>
> Can you take this patch into your net driver fixes tree?
>
> drivers/net/sb1000.c has lots of inlined static functions.
>
> Mst of them are used at initialization, wait for some
> hardware register to change (wait using yield, sleep etc),
> or do slow port-based I/O. Inlining thse "for speed" makes no sense.
>
> This patch removes "inline" from biggest static function
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
>
> Size difference for 32bit x86:
>
> text data bss dec hex filename
> 6299 129 0 6428 191c linux-2.6-ALLYES/drivers/net/sb1000.o
> 5418 129 0 5547 15ab linux-2.6.inline-ALLYES/drivers/net/sb1000.o
>
> (I also see some other optimization opportunities,
> will test and send a patch separately).
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

applied both patches




\
 
 \ /
  Last update: 2008-04-12 11:11    [W:0.030 / U:1.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site