Messages in this thread | | | Date | Sat, 12 Apr 2008 00:22:38 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 1/2] kernel: add common infrastructure for unaligned access |
| |
[Harvey Harrison - Thu, Apr 10, 2008 at 08:38:57PM -0700] [...] | + | +static inline void __put_unaligned_be16(u16 val, u8 *p) | +{ | + *p++ = val >> 8; | + *p++ = val; | +} | + [...] | +static inline void __put_unaligned_le16(u16 val, u8 *p) | +{ | + *p++ = val; | + *p++ = val >> 8; | +} [...]
Hi Harvey, do we really need second increments? I mean, wouldn't be better to use *p = val >> 8 and *p << 8?
- Cyrill -
| |