Messages in this thread | | | Date | Sat, 12 Apr 2008 18:55:41 -0700 | From | "Yinghai Lu" <> | Subject | Re: [patch 1/2] bootmem: Revert "mm: fix boundary checking in free_bootmem_core" |
| |
On Sat, Apr 12, 2008 at 3:33 PM, Johannes Weiner <hannes@saeurebad.de> wrote: > This reverts commit 5a982cbc7b3fe6cf72266f319286f29963c71b9e. > > The intention behind this patch was to make the free_bootmem() > interface more robust with regards to the specified range and to let > it operate on multiple node setups as well. > > However, it made free_bootmem_core() > > 1. handle bogus node/memory-range combination input by just > returning early without informing the callsite or screaming BUG() > as it did before > 2. round slightly out of node-range values to the node boundaries > instead of treating them as the invalid parameters they are > > This was partially done to abuse free_bootmem_core() for node > iteration in free_bootmem (just feeding it every node on the box and > let it figure out what it wants to do with it) instead of looking up > the proper node before the call to free_bootmem_core().
it seems intel having one box the [0, 4G), [8, 12G] on node 0, and [4G, 8G) and [12G, 16) on node 1.
YH
| |