lkml.org 
[lkml]   [2008]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Replace completions with semaphores
Date
 > Arnd contacted me off-list and made the very sensible suggestion of:
>
> struct completion {
> struct semaphore sem;
> }
>
> That lets us eliminate the duplicate code since all the completion
> functions become very thin wrappers around semaphore operations.

Just make sure you don't forget the history of completions... As
Linus said long ago (http://lwn.net/2001/0802/a/lt-completions.php3):

In case anybody cares, the race was that Linux semaphores only protect the
accesses _inside_ the semaphore, while the accesses by the semaphores
themselves can "race" in the internal implementation. That helps make an
efficient implementation, but it means that the race was:

cpu #1 cpu #2

DECLARE_MUTEX_LOCKED(sem);
..
down(&sem); up(&sem);
return;
wake_up(&sem.wait) /*BOOM*/


\
 
 \ /
  Last update: 2008-04-12 21:55    [W:0.179 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site