Messages in this thread | | | Date | Fri, 11 Apr 2008 10:59:28 +0200 | From | Nick Piggin <> | Subject | Re: [patch 11/17] hugetlbfs: support larger than MAX_ORDER |
| |
On Fri, Apr 11, 2008 at 10:13:17AM +0200, Andi Kleen wrote: > > spin_lock(&hugetlb_lock); > > - if (h->surplus_huge_pages_node[nid]) { > > + if (h->surplus_huge_pages_node[nid] && h->order <= MAX_ORDER) { > > As Andrew Hastings pointed out earlier this all needs to be h->order < MAX_ORDER > [got pretty much all the checks wrong off by one]. It won't affect anything > on x86-64 but might cause problems on archs which have exactly MAX_ORDER > sized huge pages.
Ah, hmm, I might have missed a couple of emails worth of feedback when you last posted. Thanks for pointing this out, I'll read over them again.
| |