lkml.org 
[lkml]   [2008]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 11/17] hugetlbfs: support larger than MAX_ORDER
On Fri, Apr 11, 2008 at 10:13:17AM +0200, Andi Kleen wrote:
> > spin_lock(&hugetlb_lock);
> > - if (h->surplus_huge_pages_node[nid]) {
> > + if (h->surplus_huge_pages_node[nid] && h->order <= MAX_ORDER) {
>
> As Andrew Hastings pointed out earlier this all needs to be h->order < MAX_ORDER
> [got pretty much all the checks wrong off by one]. It won't affect anything
> on x86-64 but might cause problems on archs which have exactly MAX_ORDER
> sized huge pages.

Ah, hmm, I might have missed a couple of emails worth of feedback when
you last posted. Thanks for pointing this out, I'll read over them again.



\
 
 \ /
  Last update: 2008-04-11 11:01    [W:0.033 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site