lkml.org 
[lkml]   [2008]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for April 10 (arch/x86)

* Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Fix printk formats in x86/mm/ioremap.c:
>
> next-20080410/arch/x86/mm/ioremap.c:137: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'resource_size_t'
> next-20080410/arch/x86/mm/ioremap.c:188: warning: format '%llx' expects type 'long long unsigned int', but argument 2 has type 'resource_size_t'
> next-20080410/arch/x86/mm/ioremap.c:188: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'long unsigned int'

thanks, applied.

> if (!phys_addr_valid(phys_addr)) {
> printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
> - phys_addr);
> + (unsigned long long)phys_addr);

is there really no way to solve this more cleanly than a forced cast? It
is a totally uninteresting warning that we pass in a narrower type to
printk(). It cannot ever cause any bugs or problems. Why does gcc warn
about it?

Ingo


\
 
 \ /
  Last update: 2008-04-11 09:49    [W:0.151 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site