Messages in this thread | | | From | David Brownell <> | Subject | Re: [PATCH] GPIO: #include <linux/kernel.h> for might_sleep | Date | Fri, 11 Apr 2008 10:05:51 -0700 |
| |
On Friday 11 April 2008, Uwe Kleine-König wrote: > I like having headers being independend of the order of inclusion.
That's a pretty unusual policy. Not one that's generally followed in the kernel, either ...
> Usually I order all includes alphabetically (and grouped by linux/, > asm/, etc.).
If you like alphabetical, why the exception for <asm/...> ?? :)
> This doesn't work with gpio.h because then kernel.h is > included to late.
So include <linux/kernel.h> first. There *is* a policy of avoiding extra #includes ... extras slow down builds.
- Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |