Messages in this thread | | | Date | Fri, 11 Apr 2008 13:09:39 +0200 | From | Ingo Molnar <> | Subject | Re: BUG: using smp_processor_id() during suspend with 2.6.25-rc8 |
| |
* Pavel Machek <pavel@ucw.cz> wrote:
> (I just want to fix the underlying problem in suspend, too. I guess > I'll just do something like
> if (drv->suspend) { > + BUG_ON(!in_interrupt()); > ret = drv->suspend(sysdev, state);
> pr_debug(" %s\n", kobject_name(&sysdev->kobj)); > > + BUG_ON(!in_interrupt()); > __sysdev_resume(sysdev);
small note: please always use WARN_ON_ONCE() in such cases. That way people's boxes dont blow up and the problem will be debuggable if the box survives despite the error condition. (and thus it can be relayed to kerneloops.org - all major distros have the package included already and Fedora enables the client by default)
Ingo
| |