Messages in this thread | | | Date | Thu, 10 Apr 2008 13:42:52 +0200 | From | Roel Kluin <> | Subject | Re: [PATCH] pagewalk: don't pte_unmap(NULL) in walk_pte_range() |
| |
Johannes Weiner wrote: > Hi, > > Roel Kluin <12o3l@tiscali.nl> writes: > >> This is right isn't it? >> --- >> Don't pte_unmap a NULL pointer, but the previous. > > Which NULL pointer? > >> Signed-off-by: Roel Kluin <12o3l@tiscali.nl> >> --- >> diff --git a/mm/pagewalk.c b/mm/pagewalk.c >> index 1cf1417..6615f0b 100644 >> --- a/mm/pagewalk.c >> +++ b/mm/pagewalk.c >> @@ -15,7 +15,7 @@ static int walk_pte_range(pmd_t *pmd, unsigned long addr, unsigned long end, >> break; >> } while (pte++, addr += PAGE_SIZE, addr != end); >> >> - pte_unmap(pte); >> + pte_unmap(pte - 1); >> return err; >> } > > This does not make any sense to me.
you are right, please ignore.
> Hannes
thanks,
Roel
| |