Messages in this thread | | | Date | Thu, 10 Apr 2008 11:59:30 +0200 | From | Rodney Lorrimar <> | Subject | Re: [PATCH] Input: adbhid - fix capslock key state after suspend |
| |
On Fri, Mar 28, 2008 at 11:58:55AM +0100, Pavel Machek wrote: > On Fri 2008-03-28 01:15:56, Rodney Lorrimar wrote: > > If the adbhid module parameter restore_capslock_events is used, > > sometimes capslock will get stuck down after resuming. > > Hmmm, why does that need to be a parameter? I mean... can we just do > the right thing?
Hi Pavel,
Sorry for taking so long to answer your questions. We can mostly do the right thing. I suppose it was a parameter so the quirk fixing didn't ruin the fun for the majority of users who don't remap their capslock. I know of two issues with the code:
1. Under heavy capslock usage the capslock key will sometimes get stuck down. 2. If the capslock LED is on and the power button is pressed, a "power button release" key event won't happen until capslock is pressed again. So in some situations (e.g. with pbbuttonsd) the next time capslock is hit the machine will suspend.
I will send a patch for 2, and continue to investigate 1.
Regarding the original patch, I think it's worth applying. If 1 is fixable then I will prepare two more patches to fix problem 1 and remove the parameter.
Rodney [unhandled content-type:application/pgp-signature] | |