Messages in this thread Patch in this message | | | Date | Thu, 10 Apr 2008 10:40:31 +0100 | From | Robert Fitzsimons <> | Subject | [PATCH] bttv: Fix memory leak in radio_release |
| |
Fix the leak of the bttv_fh structure allocated in radio_open which was introduced by commit 5cd3955cb8adfc1edf481e9e1cb2289db50ccacb.
Signed-off-by: Robert Fitzsimons <robfitz@273k.net> --- drivers/media/video/bt8xx/bttv-driver.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
Seeing as commit 'V4L/DVB (7277): bttv: Re-enabling radio support requires the use of struct bttv_fh' made it into mainline I better fix the memory leak I introduced.
Robert
diff --git a/drivers/media/video/bt8xx/bttv-driver.c b/drivers/media/video/bt8xx/bttv-driver.c index fcf8f2d..59a8847 100644 --- a/drivers/media/video/bt8xx/bttv-driver.c +++ b/drivers/media/video/bt8xx/bttv-driver.c @@ -3457,6 +3457,9 @@ static int radio_release(struct inode *inode, struct file *file) struct bttv *btv = fh->btv; struct rds_command cmd; + file->private_data = NULL; + kfree(fh); + btv->radio_user--; bttv_call_i2c_clients(btv, RDS_CMD_CLOSE, &cmd); -- 1.5.4.3.484.g60e3
| |