Messages in this thread | | | Subject | Re: [PATCH] lzo: fix possible typo in decompresor | From | Richard Purdie <> | Date | Thu, 10 Apr 2008 23:18:08 +0100 |
| |
On Thu, 2008-04-10 at 13:49 -0700, Linus Torvalds wrote: > On Thu, 10 Apr 2008, Harvey Harrison wrote: > > > > Shift of a le value seems strange, probably meant to shift the cpu-order > > variable as in the prvious section of the switch statement. > > Hmm. This patch looks ObviouslyCorrect(tm), but it worries me that > apparently the old broken code has been around since last July, and afaik > it can never have worked on big-endian machines. > > So did nobody ever use it, or why hasn't this ever triggered? How did you > find this? A sparse warning?
The heaviest users of the lzo code I know of are little-endian ARM devices through jffs2. When the code was merged there was a lot of discussion about the best way to handle the endian issues and unaligned accesses and whilst I seem to remember someone posting big-endian test results it could have been before some of the later changes were made.
So yes its possible its not been run on BE until now or that isn't a common code path. I've checked this against the external LZO library its based on and the patch is correct
Acked-by: Richard Purdie <rpurdie@rpsys.net>
-- Richard
| |