Messages in this thread | | | Date | Thu, 10 Apr 2008 09:10:57 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 2/3] x86: GEODE: add Virtual Systems Architecture detection |
| |
On Wed, 9 Apr 2008 22:33:28 -0400 Andres Salomon <dilinger@queued.net> wrote:
> > This is generic VSA detection. It's used by OLPC to determine whether or > not the BIOS contains VSA, but since other BIOSes are coming out that don't > use the VSA (ie, tinybios), it might end up being useful for others.
NAK - but minor
This is a check for *VSA2* which is not the same as VSA1 (Cyrix one) and for older systems that actually matters as you may have VSA1 or VSA2 and they are detected differently.
> +/* VSA magic values */
These should be VSA2 I think
> +static inline int geode_has_vsa(void)
has_vsa2
Alan (Keeper of the ancient cyrix docs ;))
| |