Messages in this thread | | | Date | Thu, 10 Apr 2008 13:49:22 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH] lzo: fix possible typo in decompresor |
| |
On Thu, 10 Apr 2008, Harvey Harrison wrote: > > Shift of a le value seems strange, probably meant to shift the cpu-order > variable as in the prvious section of the switch statement.
Hmm. This patch looks ObviouslyCorrect(tm), but it worries me that apparently the old broken code has been around since last July, and afaik it can never have worked on big-endian machines.
So did nobody ever use it, or why hasn't this ever triggered? How did you find this? A sparse warning?
Linus
| |