lkml.org 
[lkml]   [2008]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: local_softirq_pending()
On Wed, Apr 09, 2008 at 07:27:08PM -0700, Andrew Morton wrote:
> kernel/time/tick-sched.c: In function 'tick_nohz_stop_sched_tick':
> kernel/time/tick-sched.c:229: warning: format '%02x' expects type 'unsigned int', but argument 2 has type '__u64'
>
> I don't think the architecture's local_softirq_pending() should return u64.
> This is the sort of thing which should be consistent across architectures.
>
> Problem is, we've made such a complete mess of everything that this is a
> bitch to fix.
>
> The obvious and moderately clean fix is:

I think I will just change the type of softirq_pending in s390's struct lowcore
from __u64 to __u32. That should be the least intrusive "fix" for this problem.


\
 
 \ /
  Last update: 2008-04-10 10:11    [W:0.024 / U:0.804 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site