lkml.org 
[lkml]   [2008]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: + itimer-fix-hangs-with-many-threads.patch added to -mm tree
In message <200803312147.m2VLlbr5027658@imap1.linux-foundation.org>, akpm@linux-foundation.org writes:
>
> The patch titled
> itimer: fix hangs with many threads
> has been added to the -mm tree. Its filename is
> itimer-fix-hangs-with-many-threads.patch
>
> Before you just go and hit "reply", please:
> a) Consider who else should be cc'ed
> b) Prefer to cc a suitable mailing list as well
> c) Ideally: find the original patch on the mailing list and do a
> reply-to-all to that, adding suitable additional cc's
>
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
>
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

This patch doesn't compile for me on MMOTM (stamp-2008-04-01-02-39):

CC kernel/sys.o
kernel/sys.c: In function 'sys_times':
kernel/sys.c:885: error: 'sig' undeclared (first use in this function)
kernel/sys.c:885: error: (Each undeclared identifier is reported only once
kernel/sys.c:885: error: for each function it appears in.)
make[1]: *** [kernel/sys.o] Error 1
CC kernel/posix-cpu-timers.o
kernel/posix-cpu-timers.c: In function 'run_posix_cpu_timers':
kernel/posix-cpu-timers.c:1214: error: 'sig' undeclared (first use in this function)
kernel/posix-cpu-timers.c:1214: error: (Each undeclared identifier is reported only once
kernel/posix-cpu-timers.c:1214: error: for each function it appears in.)
make[1]: *** [kernel/posix-cpu-timers.o] Error 1

Small patch below.

Cheers,
Erez.


diff --git a/kernel/posix-cpu-timers.c b/kernel/posix-cpu-timers.c
index 325fdbe..56e9f6a 100644
--- a/kernel/posix-cpu-timers.c
+++ b/kernel/posix-cpu-timers.c
@@ -1211,7 +1211,7 @@ void run_posix_cpu_timers(struct task_struct *tsk)
virt_ticks(tsk), tsk->se.sum_exec_runtime)) {
if (unlikely(tsk->signal == NULL))
return;
- if (!sig->thread_group_times)
+ if (!tsk->signal->thread_group_times)
return;
thread_group_cputime(&tg_times, tsk->signal);
tg_prof = cputime_add(tg_times.utime, tg_times.stime);
diff --git a/kernel/sys.c b/kernel/sys.c
index c8b5ed0..cf7063a 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -882,7 +882,7 @@ asmlinkage long sys_times(struct tms __user * tbuf)
* If a POSIX interval timer is running use the process-wide
* fields, else fall back to brute force.
*/
- if (sig->thread_group_times) {
+ if (tsk->signal->thread_group_times) {
thread_group_cputime(&thread_group_times, tsk->signal);
utime = thread_group_times.utime;
stime = thread_group_times.stime;

\
 
 \ /
  Last update: 2008-04-01 22:49    [W:0.042 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site