Messages in this thread | | | From | Bjorn Helgaas <> | Subject | Re: [patch 00/37] PNP resource_table cleanups | Date | Tue, 1 Apr 2008 08:52:22 -0600 |
| |
On Tuesday 01 April 2008 04:16:10 am Rene Herman wrote: > On 31-03-08 23:38, Rene Herman wrote: > > On 31-03-08 22:51, Bjorn Helgaas wrote: > > > >> Ah, right. Thanks for tracking that down. I forgot to factor out > >> isapnp_to_pnpid() and pnpid32_to_pnpid() (and acpi_ex_eisa_id_to_string() > >> for that matter, though that's buried in the ACPI CA)-- they're really > >> doing the same thing and we should only need one copy (plus the CA > >> one). > > > > I'll wait for another round then, before reviewing this further. > > There's actually a hex_asc() helper in kernel.h, so before you overlook it > as well, this is a somewhat nicer ID fix.
Thanks, I didn't know about hex_asc()! I'll post v2 of the series today. And thanks a lot for finding those typos in resource.c. I never would have found those...
Bjorn
| |