lkml.org 
[lkml]   [2008]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 00/37] PNP resource_table cleanups
Date
On Tuesday 01 April 2008 04:16:10 am Rene Herman wrote:
> On 31-03-08 23:38, Rene Herman wrote:
> > On 31-03-08 22:51, Bjorn Helgaas wrote:
> >
> >> Ah, right. Thanks for tracking that down. I forgot to factor out
> >> isapnp_to_pnpid() and pnpid32_to_pnpid() (and acpi_ex_eisa_id_to_string()
> >> for that matter, though that's buried in the ACPI CA)-- they're really
> >> doing the same thing and we should only need one copy (plus the CA
> >> one).
> >
> > I'll wait for another round then, before reviewing this further.
>
> There's actually a hex_asc() helper in kernel.h, so before you overlook it
> as well, this is a somewhat nicer ID fix.

Thanks, I didn't know about hex_asc()! I'll post v2 of the series today.
And thanks a lot for finding those typos in resource.c. I never would
have found those...

Bjorn


\
 
 \ /
  Last update: 2008-04-01 16:55    [W:0.053 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site