lkml.org 
[lkml]   [2008]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 26/26] UBIFS: include FS to compilation
Hi Artem,

Pekka Enberg wrote:
> > Yeah, perhaps that's a sign that you're doing it wrong? You currently
> > have 430 separate debug printks sprinkled around in UBIFS.

On Tue, Apr 1, 2008 at 12:25 PM, Artem Bityutskiy
<Artem.Bityutskiy@nokia.com> wrote:
> JFFS2 has the similar thing. I myself fixed bugs just by asking people
> enabling them and sending the log. Very useful. This is why we also added
> them to UBIFS - good JFFS2 experience.
>
> Why? What is wrong with this? As I said, we found it very useful in JFFS2,
> because I has been working with JFFS2 for _long_ time. Talk to David
> Woodhouse and ask how many times that made him fix a bug just by having
> people send a log. Why do you want to prevent us from having this?

First and foremost, JFFS2 uses BUG_ON and doesn't invent it's own
assert. Furthermore, the debug tracing code prints out human-readable
text in well-thought of places. It's looks bit excessive to me and I
don't see a good reason why the different logging levels are not
run-time configurable (if you're going to invent a logging
infrastructure, why not do it properly). But there simply is no
comparison between JFFS2 and UBIFS debug logging code. The former is
cleanly structured whereas yours looks to be totally ad hoc.

But perhaps the problem will go away after you inject some sanity to
stuff like this:

fs/ubifs/dir.c: dbg_gen("dent '%.*s' to ino %lu (nlink %d) in dir ino %lu",
fs/ubifs/dir.c: dbg_gen("dent '%.*s' from ino %lu (nlink %d) in dir ino %lu",
fs/ubifs/dir.c: dbg_gen("directory '%.*s', ino %lu in dir ino %lu",
dentry->d_name.len,
fs/ubifs/dir.c: dbg_gen("dent '%.*s', mode %#x in dir ino %lu",
fs/ubifs/dir.c: dbg_gen("dent '%.*s' in dir ino %lu",

Pekka


\
 
 \ /
  Last update: 2008-04-01 12:07    [W:2.137 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site