Messages in this thread | | | Date | Tue, 01 Apr 2008 11:53:53 +0200 | From | Jiri Slaby <> | Subject | Re: [PATCH 3/4] Char: ip2, fix sparse warnings |
| |
Andrew Morton napsal(a): > On Fri, 28 Mar 2008 22:18:43 +0100 > Jiri Slaby <jirislaby@gmail.com> wrote: > >> Unlock two grabbed locks on some paths. >> >> Signed-off-by: Jiri Slaby <jirislaby@gmail.com> >> --- >> drivers/char/ip2/i2lib.c | 10 ++++++---- >> 1 files changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/char/ip2/i2lib.c b/drivers/char/ip2/i2lib.c >> index 618f5fe..1d5388c 100644 >> --- a/drivers/char/ip2/i2lib.c >> +++ b/drivers/char/ip2/i2lib.c [...] >> @@ -1834,6 +1834,8 @@ i2StripFifo(i2eBordStrPtr pB) >> default: // Neither packet? should be impossible >> ip2trace (ITRC_NO_PORT, ITRC_SFIFO, 5, 1, >> PTYPE_OF(pB->i2eLeadoffWord) ); >> + write_unlock_irqrestore(&pB->read_fifo_spinlock, >> + bflags); >> >> break; >> } // End of switch on type of packets > > Your tree apparently has a sensible-looking write_unlock_irqrestore(), > whereas mine has a stupid-looking WRITE_UNLOCK_IRQRESTORE(). How did this > happen?
This was changed in the previous wrong patch, I'm preparing a correct one.
| |