Messages in this thread | | | Date | Sun, 9 Mar 2008 13:00:05 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: quicklists confuse meminfo |
| |
On Sun, 9 Mar 2008, KOSAKI Motohiro wrote: > Hi > > in general, I like this patch and I think this is very useful. > but I don't like #ifdef ;)
/me neither :)
> > +#ifdef CONFIG_QUICKLIST > > + "QuickLists: %8lu kB\n" > > +#endif > > + ,K(i.totalram), > > K(i.freeram), > > K(i.bufferram), > > K(cached), > > @@ -215,6 +220,9 @@ static int meminfo_read_proc(char *page, > > (unsigned long)VMALLOC_TOTAL >> 10, > > vmi.used >> 10, > > vmi.largest_chunk >> 10 > > +#ifdef CONFIG_QUICKLIST > > + ,K(quicklist_total_size()) > > +#endif > > Do you dislike my following patch?
I like it. I'm just not sure about the accounting of cached memory in general, though quicklists seem to be a pretty obvious one.
Thanks,
tglx
| |