Messages in this thread | | | Subject | Re: [UPDATED v3][PATCH 4/7] regulator: framework core | From | Liam Girdwood <> | Date | Sun, 09 Mar 2008 11:18:23 +0000 |
| |
On Sat, 2008-03-08 at 10:30 -0800, Andrew Morton wrote: > On Sat, 08 Mar 2008 17:24:46 +0000 Liam Girdwood <lg@opensource.wolfsonmicro.com> wrote: > > > > Should be indented with a tab, not spacespacespacespace > > > > This patch releases the lock in get_device_regulator(), makes > > get_lowest_stable_voltage() non inline and fixes a minor indentation > > issue. > > OK, I'll toss it in there, thanks. > > It sounds like significant changes will be happening and that we can expect > to see a new patchset? >
Yep, I have some customer stuff to do at the start of the week so I'll be able to send some new patches later in the week.
> I assume you noted my s/get_current/read_current/g fix? It'll be needed for > alpha, frv and mn10300. read_current() is a pretty crappy name but I couldn't > think of anything better. It would look nicer if we also did > s/get_voltage/read_voltage/g - your call.
ok, will do.
Liam
| |