Messages in this thread | | | Date | Thu, 6 Mar 2008 23:03:10 +0030 | From | "Paolo Ciarrocchi" <> | Subject | Re: [PATCH] checkpatch: Make some text more consinstent and informative |
| |
On 3/6/08, Andy Whitcroft <apw@shadowen.org> wrote: > On Wed, Mar 05, 2008 at 09:49:12PM +0100, Paolo Ciarrocchi wrote: > > Hi Andy, > > > > Now messages about missing spaces or not needed spaces are in the format: > > space is required > > space is not required > > > > Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> > > The current version (which your patch has crossed with) has these changed > to "required" and "prohibited" respectivly, to remove the ambiguity > introduced by > tehe "no spaces X" form. > > I did consider and reject the "is not required" form. In english this > does not correct carry the "must not be present" meaning, it more means > "may or may not be present at your option". Which is not what we are > trying to say either.
yes, i tend to agree.
> Hopefully the new wording is clearer to native and non-native english > speakers alike.
i had a look at the next branch, i really like the new output. Very nice work.
> Thanks for doing the patch even so.
you are welcome, i'll keep tracking the next branch.
ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/
| |