Messages in this thread | | | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [patch 3/3] pata: "I do not think it means, what you think it means." | Date | Wed, 5 Mar 2008 02:54:57 +0100 |
| |
On Wednesday 05 March 2008, Andrew Morton wrote: > On Wed, 5 Mar 2008 02:34:40 +0100 > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > On Wednesday 05 March 2008, akpm@linux-foundation.org wrote: > > > From: Alan Cox <alan@lxorguk.ukuu.org.uk> > > > > > > When masking mask out the modes that are unsupported not the ones that are > > > supported. This makes life happier. > > > > > > > Jeff, > > > > Could we get this merged ASAP (it was first posted on 26th February)? > > > > This patch fixes data corruption for libata PATA ServerWorks and HPT drivers. > > > > [ IDE users are already leaving happy life since they are not affected > > (modes masking has always worked correctly in the original drivers)... > > > > Can we make life happy also for libata PATA users? :) ] > > > > (edited to undo top-posting damage) > > I didn't know any of that. The changelog might have been kinda fun, but > given that it failed to tell us that the patch fixes data-corruption > errors, the changelog was excrutiatingly bad. > > Do we need this fix in 2.6.24.x as well?
Let me quote Alan's opinion on this:
"I think that would be wise ;)"
nothing needs to be added here ;)
| |