lkml.org 
[lkml]   [2008]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: preempt bug in set_pmd_pfn?
Ingo Molnar wrote:
> * Jeremy Fitzhardinge <jeremy@goop.org> wrote:
>
>
>> I think set_pmd_pfn, which is only called by __set_fixmap, might have
>> a preempt bug in it.
>>
>
> yes, and we had similar preemption bugs in the past. I guess most places
> are either infrequent or have some natural atomicity anyway. Wanna send
> a patch?
>

Sure. Should it just disable preemption, or take a lock? It calls
set_pte_at without holding any pte locks; that seems to be relatively
common. Is it OK when you're operating on init_mm?

J


\
 
 \ /
  Last update: 2008-03-04 22:37    [W:0.093 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site