Messages in this thread |  | | Date | Mon, 31 Mar 2008 21:21:19 +1000 | From | "Dave Airlie" <> | Subject | Re: [PATCH] x86: create array based interface to change page attribute |
| |
On Mon, Mar 31, 2008 at 5:25 PM, Andi Kleen <andi@firstfloor.org> wrote: > Dave Airlie <airlied@redhat.com> writes: > > > > +#define CPA_FLUSHTLB 1 > > +#define CPA_ARRAY 2 > > I don't think CPA_ARRAY should be a separate case. Rather single > page flushing should be an array with only a single entry. pageattr > is already very complex, no need to make add more special cases.
I thought about this but the current interface takes a start address and number of pages from that point to cpa, the array interface takes an array of page sized pages.
I don't really think we need to generate an array in the first case with all the pages in it..
Dave.
|  |