Messages in this thread | | | Date | Sun, 30 Mar 2008 07:31:30 +0200 (CEST) | From | Jan Engelhardt <> | Subject | Re: style of function definitions (Re: [patch] bkl2mtd: cleanup) |
| |
On Sunday 2008-03-30 06:29, Oleg Verych wrote: > [] >>>> -static int block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len, >>>> +static int >>>> +block2mtd_write(struct mtd_info *mtd, loff_t to, size_t len, >>>> size_t *retlen, const u_char *buf) >>> >>> Again, why split it that way? >> >> these are really nuances, so unless you are interested in such nuances >> nowhere found in CodingStyle, stop reading here :-) > > Nuances, or not, there are all kinds of stuff in Linux. Very small > journey from simple `grep` and trivial multi-line `sed` to a huge > discovery can be found here: > > http://kernelnewbies.org/olecom#Function_definitions > > No matter what coding style is, the winner is "linux-2.6/fs/xfs", and > i doubt anyone can fix that :)
They at least have an excuse of having a historical unix background :)
| |