lkml.org 
[lkml]   [2008]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH] fix the broken annotations in fsldma
Date
From
Hi, 

> -----Original Message-----
> From: Al Viro [mailto:viro@ftp.linux.org.uk] On Behalf Of Al Viro
>
> On Sat, Mar 29, 2008 at 09:02:02AM -0500, Josh Boyer wrote:
> > On Sat, 2008-03-29 at 03:10 +0000, Al Viro wrote:
> > > a) every bitwise declaration will give a unique type; use
> typedefs.
> > > b) no need to bother with the stuff pointed to by iomem
> pointers, unless
> > > it's accessed directly. noderef will force us to use
> helpers anyway.
>
> > Did you forget to do the s/u{32,64}/v{32,64}/ conversion for this
> > struct, or am I just a moron?
>
> See (b) above.
>

Do you mean if we do it with a known 'force' casting, we do not need the
compiler check's help?

Thanks!
Wei.


\
 
 \ /
  Last update: 2008-03-31 04:15    [W:0.024 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site